summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-12-30 21:36:31 +1100
committerAndrew Tridgell <tridge@samba.org>2010-01-02 08:16:56 +1100
commit335af02218fbee7b02cbd1e4e6b40acff288465f (patch)
tree77cf844f94eb7b717c1e6aee2e29f662fe6959bd
parent8eaed073a7c60986ecd02c3cc4beb53bd66772c6 (diff)
downloadsamba-335af02218fbee7b02cbd1e4e6b40acff288465f.tar.gz
samba-335af02218fbee7b02cbd1e4e6b40acff288465f.tar.bz2
samba-335af02218fbee7b02cbd1e4e6b40acff288465f.zip
s4-ldb: fixed valgrind error: ares can be freed by callback
-rw-r--r--source4/lib/ldb/common/ldb_modules.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/source4/lib/ldb/common/ldb_modules.c b/source4/lib/ldb/common/ldb_modules.c
index 5e9d0e6e98..3b8934702a 100644
--- a/source4/lib/ldb/common/ldb_modules.c
+++ b/source4/lib/ldb/common/ldb_modules.c
@@ -829,10 +829,7 @@ int ldb_module_done(struct ldb_request *req,
ldb_debug_end(req->handle->ldb, LDB_DEBUG_TRACE);
}
- req->callback(req, ares);
- /* returning ares->error here allows the callback routines in
- modules to override the error code */
- return ares->error;
+ return req->callback(req, ares);
}
/* to be used *only* in modules init functions.