summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJelmer Vernooij <jelmer@samba.org>2003-08-14 19:57:23 +0000
committerJelmer Vernooij <jelmer@samba.org>2003-08-14 19:57:23 +0000
commit38f09f326fc727c1a23b8c768b5c02cde7f3eceb (patch)
treef332e5555425d718d32b01bf593786db975f8972
parentfbf072599b1fb82f2f2fc7a7d53929e204c9d1c4 (diff)
downloadsamba-38f09f326fc727c1a23b8c768b5c02cde7f3eceb.tar.gz
samba-38f09f326fc727c1a23b8c768b5c02cde7f3eceb.tar.bz2
samba-38f09f326fc727c1a23b8c768b5c02cde7f3eceb.zip
Fix overflow in vfs_recycle module (and hopefully also bug #291)
(This used to be commit 8625f0e015481a79b0a7dedb77c60ce7b2cb7b84)
-rw-r--r--source3/modules/vfs_recycle.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c
index e725daedba..c0b331b862 100644
--- a/source3/modules/vfs_recycle.c
+++ b/source3/modules/vfs_recycle.c
@@ -455,7 +455,8 @@ static int recycle_unlink(vfs_handle_struct *handle, connection_struct *conn, co
/* rename file we move to recycle bin */
i = 1;
while (recycle_file_exist(handle, final_name)) {
- snprintf(final_name, PATH_MAX -1, "%s/Copy #%d of %s", temp_name, i++, base);
+ SAFE_FREE(final_name);
+ asprintf(&final_name, "%s/Copy #%d of %s", temp_name, i++, base);
}
DEBUG(10, ("recycle: Moving %s to %s\n", file_name, final_name));