summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2009-10-19 14:17:02 +1100
committerAndrew Tridgell <tridge@samba.org>2009-10-19 14:17:02 +1100
commit38fbfdca4d4234875f15571f7c90eff0078b6b2c (patch)
tree4d8b065c339ab2ce46fe25c6cb667a19bfb2b8be
parentfb9319d971b0dfe46bfaca5c161ee078e9f59875 (diff)
downloadsamba-38fbfdca4d4234875f15571f7c90eff0078b6b2c.tar.gz
samba-38fbfdca4d4234875f15571f7c90eff0078b6b2c.tar.bz2
samba-38fbfdca4d4234875f15571f7c90eff0078b6b2c.zip
Revert "selftest: fixed filter to know about a "error" result"
This reverts commit 1de7e43fb4a4863e3663af8b2a2d9f19cf82d7f3. This is much more delicate than it seems
-rw-r--r--selftest/Subunit/Filter.pm12
1 files changed, 3 insertions, 9 deletions
diff --git a/selftest/Subunit/Filter.pm b/selftest/Subunit/Filter.pm
index 2b390d189a..93b690df8e 100644
--- a/selftest/Subunit/Filter.pm
+++ b/selftest/Subunit/Filter.pm
@@ -76,12 +76,6 @@ sub start_test($$)
Subunit::start_test($testname);
}
-sub is_failure($)
-{
- my ($result) = @_;
- return $result eq "fail" or $result eq "failure" or $result eq "error";
-}
-
sub end_test($$$$$)
{
my ($self, $testname, $result, $unexpected, $reason) = @_;
@@ -90,12 +84,12 @@ sub end_test($$$$$)
$testname = $self->{prefix}.$testname;
}
- if (is_failure($result) and not $unexpected) {
+ if (($result eq "fail" or $result eq "failure") and not $unexpected) {
$result = "xfail";
$self->{xfail_added}++;
}
my $xfail_reason = find_in_list($self->{expected_failures}, $testname);
- if (defined($xfail_reason) and is_failure($result)) {
+ if (defined($xfail_reason) and ($result eq "fail" or $result eq "failure")) {
$result = "xfail";
$self->{xfail_added}++;
$reason .= $xfail_reason;
@@ -127,7 +121,7 @@ sub start_testsuite($;$)
sub end_testsuite($$;$)
{
my ($self, $name, $result, $reason) = @_;
- if ($self->{xfail_added} and is_failure($result)) {
+ if ($self->{xfail_added} and ($result eq "fail" or $result eq "failure")) {
$result = "xfail";
}