diff options
| author | Jeremy Allison <jra@samba.org> | 1997-10-04 00:23:57 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 1997-10-04 00:23:57 +0000 |
| commit | 3c5998e29be2ce035d71b211aa992e38b5cf7904 (patch) | |
| tree | df59da94f1ce1c264f529115a8eb01b6a08b710b | |
| parent | c89eaa20d14c46c70980598345d7aa9394bcd854 (diff) | |
| download | samba-3c5998e29be2ce035d71b211aa992e38b5cf7904.tar.gz samba-3c5998e29be2ce035d71b211aa992e38b5cf7904.tar.bz2 samba-3c5998e29be2ce035d71b211aa992e38b5cf7904.zip | |
Race condition with multiple oplock break requests happens
more often than you might think (reproduced here with 4 clients
and netbench :-).
Raising debug log level for report from 1 to 3.
Jeremy (jallison@whistle.com)
(This used to be commit 23eeab7aa2e9c935e1f48ce3449544c03c1c899f)
| -rw-r--r-- | source3/smbd/server.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/source3/smbd/server.c b/source3/smbd/server.c index 52869505c0..b250572a1f 100644 --- a/source3/smbd/server.c +++ b/source3/smbd/server.c @@ -2626,13 +2626,12 @@ allowing break to succeed.\n", dev, inode, fnum)); have been broken due to another udp request, and yet there are still oplock break messages being sent in the udp message queue for this file. So return true if we don't have an oplock, - as we may have just freed it. But this is an unusual case so - we should log a message at low debug priority (1). + as we may have just freed it. */ if(!fsp->granted_oplock) { - DEBUG(1,("oplock_break: file %s (fnum = %d, dev = %x, inode = %x) has no oplock. \ + DEBUG(3,("oplock_break: file %s (fnum = %d, dev = %x, inode = %x) has no oplock. \ Allowing break to succeed regardless.\n", fsp->name, fnum, dev, inode)); return True; } |