diff options
| author | Andrew Tridgell <tridge@samba.org> | 2006-09-08 05:43:08 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 14:17:56 -0500 |
| commit | 5622eb1deec3f2ac4d0aa72e99e0ed300b9e9d05 (patch) | |
| tree | fcd0eca3679b8ebdd1acf783b7ee4ab358e9888c | |
| parent | 71a9ca56d0052ecfb1f76f9c8a3535f3bc11b0e6 (diff) | |
| download | samba-5622eb1deec3f2ac4d0aa72e99e0ed300b9e9d05.tar.gz samba-5622eb1deec3f2ac4d0aa72e99e0ed300b9e9d05.tar.bz2 samba-5622eb1deec3f2ac4d0aa72e99e0ed300b9e9d05.zip | |
r18254: reverted r18231
Jelmer, older versions of gcc don't support visibility("default"). See
for example the CentOS build here:
http://build.samba.org/?function=View+Build;host=lithium;tree=samba4;compiler=gcc;revision=18253
Is there some other way you can think of to do this?
(This used to be commit 76496c2f5e37b735e0b303ae20824c92bfa30974)
| -rw-r--r-- | source4/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/source4/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm b/source4/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm index d409450a80..9e4388e28d 100644 --- a/source4/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm +++ b/source4/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm @@ -208,8 +208,7 @@ sub fn_declare($$$) if (has_property($fn, "public")) { pidl_hdr "$decl;"; - pidl "__attribute__((visibility(\"default\")))"; - pidl "$decl"; + pidl "_PUBLIC_ $decl"; } else { pidl "static $decl"; } @@ -1880,8 +1879,7 @@ sub ParseTypedefPrint($) return if (has_property($e, "noprint")); - pidl "__attribute__((visibility(\"default\")))"; - pidl "void ndr_print_$e->{NAME}(struct ndr_print *ndr, const char *name, $args)"; + pidl "_PUBLIC_ void ndr_print_$e->{NAME}(struct ndr_print *ndr, const char *name, $args)"; pidl "{"; indent; $typefamily{$e->{DATA}->{TYPE}}->{PRINT_FN_BODY}->($e->{DATA}, $e->{NAME}); @@ -1919,8 +1917,7 @@ sub ParseFunctionPrint($) return if has_property($fn, "noprint"); - pidl "__attribute__((visibility(\"default\")))"; - pidl "void ndr_print_$fn->{NAME}(struct ndr_print *ndr, const char *name, int flags, const struct $fn->{NAME} *r)"; + pidl "_PUBLIC_ void ndr_print_$fn->{NAME}(struct ndr_print *ndr, const char *name, int flags, const struct $fn->{NAME} *r)"; pidl "{"; indent; @@ -2383,11 +2380,6 @@ sub GenerateIncludes() pidl choose_header("librpc/gen_ndr/ndr_dcerpc.h", "gen_ndr/ndr_dcerpc.h"); pidl choose_header("librpc/rpc/dcerpc.h", "dcerpc.h"); #FIXME: This shouldn't be here! } - - pidl "/* define dummy __attribute__ for systems that don't have it */"; - pidl "#if !(defined(__GNUC__) || defined(__GNUG__) || defined(__attribute__))"; - pidl "#define __attribute__(p) /* nothing */"; - pidl "#endif"; } ##################################################################### |