diff options
| author | Stefan Metzmacher <metze@samba.org> | 2012-08-08 05:33:50 +0200 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2012-08-08 05:37:49 +0200 |
| commit | 5f7d786b08f2d67d200fb473b12781174a69e776 (patch) | |
| tree | 3d3719ad90f863af17d2259d75ecb35e351b0177 | |
| parent | c9ecfd6f3df2714bfaabb77ceb987ce65c62e38a (diff) | |
| download | samba-5f7d786b08f2d67d200fb473b12781174a69e776.tar.gz samba-5f7d786b08f2d67d200fb473b12781174a69e776.tar.bz2 samba-5f7d786b08f2d67d200fb473b12781174a69e776.zip | |
s3:smb2_sesssetup: remove TALLOC_FREE(session) from smbd_smb2_[re]auth_generic_return
The caller does this via the smbd_smb2_session_setup_state_destructor()
metze
| -rw-r--r-- | source3/smbd/smb2_sesssetup.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/source3/smbd/smb2_sesssetup.c b/source3/smbd/smb2_sesssetup.c index 474c04bc9d..8876d38996 100644 --- a/source3/smbd/smb2_sesssetup.c +++ b/source3/smbd/smb2_sesssetup.c @@ -208,7 +208,6 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, sizeof(session_key)); if (x->global->signing_key.data == NULL) { ZERO_STRUCT(session_key); - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } @@ -226,7 +225,6 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, x->global->signing_key); if (x->global->application_key.data == NULL) { ZERO_STRUCT(session_key); - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } @@ -244,7 +242,6 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, x->global->channels[0].signing_key = data_blob_dup_talloc(x->global->channels, x->global->signing_key); if (x->global->channels[0].signing_key.data == NULL) { - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } @@ -252,13 +249,11 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, session_info->session_key = data_blob_dup_talloc(session_info, x->global->application_key); if (session_info->session_key.data == NULL) { - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } session->compat = talloc_zero(session, struct user_struct); if (session->compat == NULL) { - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } session->compat->session = session; @@ -278,7 +273,6 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, DEBUG(1, ("smb2: Failed to claim session " "for vuid=%llu\n", (unsigned long long)session->compat->vuid)); - TALLOC_FREE(session); return NT_STATUS_LOGON_FAILURE; } @@ -300,7 +294,6 @@ static NTSTATUS smbd_smb2_auth_generic_return(struct smbXsrv_session *session, DEBUG(0, ("smb2: Failed to update session for vuid=%llu - %s\n", (unsigned long long)session->compat->vuid, nt_errstr(status))); - TALLOC_FREE(session); return NT_STATUS_LOGON_FAILURE; } @@ -334,7 +327,6 @@ static NTSTATUS smbd_smb2_reauth_generic_return(struct smbXsrv_session *session, session_info->session_key = data_blob_dup_talloc(session_info, x->global->application_key); if (session_info->session_key.data == NULL) { - TALLOC_FREE(session); return NT_STATUS_NO_MEMORY; } @@ -363,7 +355,6 @@ static NTSTATUS smbd_smb2_reauth_generic_return(struct smbXsrv_session *session, DEBUG(0, ("smb2: Failed to update session for vuid=%llu - %s\n", (unsigned long long)session->compat->vuid, nt_errstr(status))); - TALLOC_FREE(session); return NT_STATUS_LOGON_FAILURE; } |