diff options
| author | Michael Adam <obnox@samba.org> | 2008-01-24 22:47:49 +0100 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2008-01-25 01:42:22 +0100 |
| commit | 614ba32b221aee268b86033ee10da4dbdb087365 (patch) | |
| tree | d7fa1c46fd2292bec0ca563579956f89b95006ea | |
| parent | d490d8d52d929076b2e5ab54ae0a9aff2d836677 (diff) | |
| download | samba-614ba32b221aee268b86033ee10da4dbdb087365.tar.gz samba-614ba32b221aee268b86033ee10da4dbdb087365.tar.bz2 samba-614ba32b221aee268b86033ee10da4dbdb087365.zip | |
Fix assignment to request->data.init_conn.is_primary in init_child_connection().
The present assignment
"request->data.init_conn.is_primary = domain->internal ? False : True"
simply feels wrong. This seems to be the thing right to do:
"request->data.init_conn.is_primary = domain->primary ? true : false".
The question is: Does this have any purpose at all?
data.init_conn.is_primary seems to be used nowhere
in the whole code at all.
Is it (still) needed?
Michael
(This used to be commit 8bb21b8b3802e7b093a3c4fb41b8550033388878)
| -rw-r--r-- | source3/winbindd/winbindd_util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/winbindd/winbindd_util.c b/source3/winbindd/winbindd_util.c index 0381053331..724cce2512 100644 --- a/source3/winbindd/winbindd_util.c +++ b/source3/winbindd/winbindd_util.c @@ -571,7 +571,7 @@ enum winbindd_result init_child_connection(struct winbindd_domain *domain, /* The primary domain has to find the DC name itself */ request->cmd = WINBINDD_INIT_CONNECTION; fstrcpy(request->domain_name, domain->name); - request->data.init_conn.is_primary = domain->internal ? False : True; + request->data.init_conn.is_primary = domain->primary ? true : false; fstrcpy(request->data.init_conn.dcname, ""); async_request(mem_ctx, &domain->child, request, response, init_child_recv, state); |