diff options
| author | Stefan Metzmacher <metze@samba.org> | 2012-09-20 16:16:03 +0200 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2012-09-22 10:19:00 +0200 |
| commit | 65a81060093cf9d7c0ebf8d6e160625bdc87baab (patch) | |
| tree | 777b37e9276b0ccdaf322c3ed68994b73b60cbcd | |
| parent | 882cee0acb9c1e2105a005f0ea90691197a696c7 (diff) | |
| download | samba-65a81060093cf9d7c0ebf8d6e160625bdc87baab.tar.gz samba-65a81060093cf9d7c0ebf8d6e160625bdc87baab.tar.bz2 samba-65a81060093cf9d7c0ebf8d6e160625bdc87baab.zip | |
s3:smb2_lock: smbd_smb2_notify_recv() can already return NT_STATUS_CANCELED
That's why we can remove the code that violates the tevent_req layers.
metze
| -rw-r--r-- | source3/smbd/smb2_notify.c | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/source3/smbd/smb2_notify.c b/source3/smbd/smb2_notify.c index 2c598e8d66..638e01ad7b 100644 --- a/source3/smbd/smb2_notify.c +++ b/source3/smbd/smb2_notify.c @@ -112,24 +112,6 @@ static void smbd_smb2_request_notify_done(struct tevent_req *subreq) NTSTATUS status; NTSTATUS error; /* transport error */ - if (req->cancelled) { - struct smbd_smb2_notify_state *state = tevent_req_data(subreq, - struct smbd_smb2_notify_state); - const uint8_t *inhdr = SMBD_SMB2_IN_HDR_PTR(req); - uint64_t mid = BVAL(inhdr, SMB2_HDR_MESSAGE_ID); - - DEBUG(10,("smbd_smb2_request_notify_done: cancelled mid %llu\n", - (unsigned long long)mid )); - error = smbd_smb2_request_error(req, NT_STATUS_CANCELLED); - if (!NT_STATUS_IS_OK(error)) { - smbd_server_connection_terminate(req->sconn, - nt_errstr(error)); - return; - } - TALLOC_FREE(state->im); - return; - } - status = smbd_smb2_notify_recv(subreq, req, &out_output_buffer); |