summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2006-07-25 07:48:23 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 14:10:22 -0500
commit79f7b58630e996ec734acb10e1fb99991979fe1b (patch)
tree3fd71b3bdfb672eb501cf7e2269855daebb8a0ba
parente3df3cd55ffd03a337ac769540d1cd80e25a7ef6 (diff)
downloadsamba-79f7b58630e996ec734acb10e1fb99991979fe1b.tar.gz
samba-79f7b58630e996ec734acb10e1fb99991979fe1b.tar.bz2
samba-79f7b58630e996ec734acb10e1fb99991979fe1b.zip
r17226: add some comments about ldap binds and pending requests
metze (This used to be commit e8db1fb55833ab7b9e0be391ff822b34682cb38c)
-rw-r--r--source4/ldap_server/ldap_bind.c14
1 files changed, 14 insertions, 0 deletions
diff --git a/source4/ldap_server/ldap_bind.c b/source4/ldap_server/ldap_bind.c
index daa82c1e48..0e7a147e52 100644
--- a/source4/ldap_server/ldap_bind.c
+++ b/source4/ldap_server/ldap_bind.c
@@ -125,6 +125,12 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call)
conn = call->conn;
+ /*
+ * TODO: a SASL bind with a different mechanism
+ * should cancel an inprogress SASL bind.
+ * (see RFC 4513)
+ */
+
if (!conn->gensec) {
conn->session_info = NULL;
@@ -268,6 +274,14 @@ NTSTATUS ldapsrv_BindRequest(struct ldapsrv_call *call)
struct ldapsrv_reply *reply;
struct ldap_BindResponse *resp;
+ /*
+ * TODO: we should fail the bind request
+ * if there're any pending requests.
+ *
+ * also a simple bind should cancel an
+ * inprogress SASL bind.
+ * (see RFC 4513)
+ */
switch (req->mechanism) {
case LDAP_AUTH_MECH_SIMPLE:
return ldapsrv_BindSimple(call);