summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2003-03-06 07:36:08 +0000
committerMartin Pool <mbp@samba.org>2003-03-06 07:36:08 +0000
commit7a3cc345e0508848b0e2bd492789973bcf2d5841 (patch)
tree6fdd27ef4853859750f8b3d7f0088bc8e9fc7af2
parent6149dfd3e7b9848720d18ad2c095b1f5e58ffd86 (diff)
downloadsamba-7a3cc345e0508848b0e2bd492789973bcf2d5841.tar.gz
samba-7a3cc345e0508848b0e2bd492789973bcf2d5841.tar.bz2
samba-7a3cc345e0508848b0e2bd492789973bcf2d5841.zip
FIXME about crash on failure case.
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)
-rw-r--r--source3/torture/torture.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index 2f779b9c89..60d7c2ba74 100644
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -2922,12 +2922,15 @@ static BOOL run_deletetest(int dummy)
printf("finished delete test\n");
fail:
-
+ /* FIXME: This will crash if we aborted before cli2 got
+ * intialized, because these functions don't handle
+ * uninitialized connections. */
+
cli_close(&cli1, fnum1);
cli_close(&cli1, fnum2);
cli_setatr(&cli1, fname, 0, 0);
cli_unlink(&cli1, fname);
-
+
if (!torture_close_connection(&cli1)) {
correct = False;
}