summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim McDonough <jmcd@samba.org>2011-05-25 10:49:41 -0400
committerJim McDonough <jmcd@samba.org>2011-05-25 18:11:10 +0200
commitb58534f1fca27e3e72f4f4107538ec05734bd42a (patch)
treecefed66bf710ed71dcd4951327dfdde391c2a725
parentff47927fb960b9a6c9a1ca7236dc4562c5a68461 (diff)
downloadsamba-b58534f1fca27e3e72f4f4107538ec05734bd42a.tar.gz
samba-b58534f1fca27e3e72f4f4107538ec05734bd42a.tar.bz2
samba-b58534f1fca27e3e72f4f4107538ec05734bd42a.zip
s3-winbind: BUG 8166 - Don't lockout users when offline.
Windows does not track bad password attempts when offline. We were locking users out but not honoring the lockout duration. Autobuild-User: Jim McDonough <jmcd@samba.org> Autobuild-Date: Wed May 25 18:11:10 CEST 2011 on sn-devel-104
-rw-r--r--source3/winbindd/winbindd_pam.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index e1422e5cce..e5ad2e00b0 100644
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -993,7 +993,10 @@ static NTSTATUS winbindd_dual_pam_auth_cached(struct winbindd_domain *domain,
}
- /* User does *NOT* know the correct password, modify info3 accordingly */
+ /* User does *NOT* know the correct password, modify info3 accordingly, but only if online */
+ if (domain->online == false) {
+ goto failed;
+ }
/* failure of this is not critical */
result = get_max_bad_attempts_from_lockout_policy(domain, state->mem_ctx, &max_allowed_bad_attempts);