summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2012-04-23 13:47:46 +1000
committerAndrew Bartlett <abartlet@samba.org>2012-04-23 06:12:09 +0200
commitbb3d983f5bc4b49619f26af44c3c540c3030155f (patch)
treee21893dc677a0a356172e82894b3376e2f0e15f4
parent3969cc28e8c33a65f659dbea34486a912103a2bf (diff)
downloadsamba-bb3d983f5bc4b49619f26af44c3c540c3030155f.tar.gz
samba-bb3d983f5bc4b49619f26af44c3c540c3030155f.tar.bz2
samba-bb3d983f5bc4b49619f26af44c3c540c3030155f.zip
s4-libnet: Fix segfault shown by wbinfo --group-info=administrator
The issue was that after the LookupNames call indicated that this was not a group, the call paths diverged, with both sucess and failure paths running. Andrew Bartlett
-rw-r--r--source4/libnet/libnet_group.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source4/libnet/libnet_group.c b/source4/libnet/libnet_group.c
index 5d8f9e200a..b12037e1f3 100644
--- a/source4/libnet/libnet_group.c
+++ b/source4/libnet/libnet_group.c
@@ -337,6 +337,7 @@ static void continue_name_found(struct composite_context *ctx)
if (s->lookup.out.sid_type != SID_NAME_DOM_GRP &&
s->lookup.out.sid_type != SID_NAME_ALIAS) {
composite_error(c, NT_STATUS_NO_SUCH_GROUP);
+ return;
}
/* prepare arguments for groupinfo call */