summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2010-08-17 08:05:14 +0200
committerStefan Metzmacher <metze@samba.org>2010-08-20 14:23:41 +0200
commitc9621a8c005cfc547a26dd92b8183b43665eec5c (patch)
treee7c3b4a481e2f65a9a2c2846d5da6c6feaa616e3
parent5c272b8ce7d0ffc9ce6b2ff780aa6f9e54415840 (diff)
downloadsamba-c9621a8c005cfc547a26dd92b8183b43665eec5c.tar.gz
samba-c9621a8c005cfc547a26dd92b8183b43665eec5c.tar.bz2
samba-c9621a8c005cfc547a26dd92b8183b43665eec5c.zip
s3:winbindd: fix error handling in wb_next_grent_fetch_done()
We should not use 'result' uninitialized. metze
-rw-r--r--source3/winbindd/wb_next_grent.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/source3/winbindd/wb_next_grent.c b/source3/winbindd/wb_next_grent.c
index 523f8cda8a..1c906bd9dd 100644
--- a/source3/winbindd/wb_next_grent.c
+++ b/source3/winbindd/wb_next_grent.c
@@ -100,7 +100,15 @@ static void wb_next_grent_fetch_done(struct tevent_req *subreq)
status = dcerpc_wbint_QueryGroupList_recv(subreq, state, &result);
TALLOC_FREE(subreq);
- if (!NT_STATUS_IS_OK(status) || !NT_STATUS_IS_OK(result)) {
+ if (!NT_STATUS_IS_OK(status)) {
+ /* Ignore errors here, just log it */
+ DEBUG(10, ("query_user_list for domain %s returned %s\n",
+ state->gstate->domain->name,
+ nt_errstr(status)));
+ tevent_req_nterror(req, status);
+ return;
+ }
+ if (!NT_STATUS_IS_OK(result)) {
/* Ignore errors here, just log it */
DEBUG(10, ("query_user_list for domain %s returned %s/%s\n",
state->gstate->domain->name,