summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@sernet.de>2008-08-16 11:17:09 +0200
committerJeremy Allison <jra@samba.org>2008-08-16 10:34:42 -0700
commitcb9dc23600006f2650e60d0c601d8dc5ef68fdfa (patch)
tree2efbc3127bb80c2942cbd6461e3b70d629e91c20
parent63ff9e008147b105316dcb0ea2df9b4304a8851e (diff)
downloadsamba-cb9dc23600006f2650e60d0c601d8dc5ef68fdfa.tar.gz
samba-cb9dc23600006f2650e60d0c601d8dc5ef68fdfa.tar.bz2
samba-cb9dc23600006f2650e60d0c601d8dc5ef68fdfa.zip
Attempt to fix Coverity ID 595
is_ipaddress already dereferences "name", so the NULL check is pointless after calling it. (This used to be commit 31ca7b2dbbbfbb3a55670b58c08ebda68888af7e)
-rw-r--r--source3/libcli/nbt/nbtname.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/libcli/nbt/nbtname.c b/source3/libcli/nbt/nbtname.c
index 2025ef70e7..fbb9550655 100644
--- a/source3/libcli/nbt/nbtname.c
+++ b/source3/libcli/nbt/nbtname.c
@@ -420,7 +420,7 @@ _PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx,
n->scope = NULL;
n->type = type;
- if (is_ipaddress(name) || name == NULL) {
+ if ((name == NULL) || is_ipaddress(name)) {
n->name = "*SMBSERVER";
return;
}