summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2007-07-17 02:17:23 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 12:28:41 -0500
commitcfb7c04696f0ac4306a6e1847212fed44f6b2cd5 (patch)
treedc942d68492468b806ff2c0a1877000bf849c979
parent5e3e15f754a9bc6412f6172d454f815e5b71307b (diff)
downloadsamba-cfb7c04696f0ac4306a6e1847212fed44f6b2cd5.tar.gz
samba-cfb7c04696f0ac4306a6e1847212fed44f6b2cd5.tar.bz2
samba-cfb7c04696f0ac4306a6e1847212fed44f6b2cd5.zip
r23910: We used to deny renames on the
source open for non-delete open. Turns out this is not the case. VL please test but this matches Windows behaviour. (I'll add a torture test tomorrow). Jeremy. (This used to be commit 03e3d587468ce66044814a8a58308b2fe9ab5499)
-rw-r--r--source3/smbd/reply.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index e3ae0ef7f6..2135299df0 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -1863,6 +1863,12 @@ static NTSTATUS can_rename(connection_struct *conn, files_struct *fsp,
return NT_STATUS_NO_SUCH_FILE;
}
+#if 0
+ /* We used to deny renames on the
+ * source open for non-delete open.
+ * Turns out this is not the case.
+ * VL please test but this matches
+ * Windows behaviour. JRA. */
if (S_ISDIR(pst->st_mode)) {
return NT_STATUS_OK;
}
@@ -1872,6 +1878,9 @@ static NTSTATUS can_rename(connection_struct *conn, files_struct *fsp,
}
return NT_STATUS_ACCESS_DENIED;
+#else
+ return NT_STATUS_OK;
+#endif
}
/*******************************************************************