summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2012-12-06 11:24:17 +0100
committerGünther Deschner <gd@samba.org>2012-12-12 15:00:02 +0100
commitd862bbd5dcffa3f1cb8e774724132a39b55dbd9f (patch)
treeadf4bae767e24715d74d212084e930c3f8177e92
parentc9053796b389758e8bacff4cd37d633fd65171f9 (diff)
downloadsamba-d862bbd5dcffa3f1cb8e774724132a39b55dbd9f.tar.gz
samba-d862bbd5dcffa3f1cb8e774724132a39b55dbd9f.tar.bz2
samba-d862bbd5dcffa3f1cb8e774724132a39b55dbd9f.zip
winbind: Use talloc in resolve_alias_to_username().
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
-rw-r--r--source3/winbindd/winbindd_cache.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index e3406a5858..ffed27b397 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -1189,16 +1189,18 @@ NTSTATUS resolve_alias_to_username( TALLOC_CTX *mem_ctx,
if (!cache->tdb)
goto do_query;
- if ( (upper_name = SMB_STRDUP(alias)) == NULL )
+ upper_name = talloc_strdup(mem_ctx, alias);
+ if (upper_name == NULL) {
return NT_STATUS_NO_MEMORY;
+ }
if (!strupper_m(upper_name)) {
- SAFE_FREE(upper_name);
+ talloc_free(upper_name);
return NT_STATUS_INVALID_PARAMETER;
}
centry = wcache_fetch(cache, domain, "NSS/AN/%s", upper_name);
- SAFE_FREE( upper_name );
+ talloc_free(upper_name);
if (!centry)
goto do_query;