summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2012-06-11 10:35:38 +0200
committerStefan Metzmacher <metze@samba.org>2012-06-11 15:30:54 +0200
commite1a4d3cdd455616a9c6cb0cff543de2b5fdc2766 (patch)
treefabdb9bc53386459573f0c1e024dfc1e508972d2
parentc2094e313118c29e1e7540ca8f06f9fe0bd30e16 (diff)
downloadsamba-e1a4d3cdd455616a9c6cb0cff543de2b5fdc2766.tar.gz
samba-e1a4d3cdd455616a9c6cb0cff543de2b5fdc2766.tar.bz2
samba-e1a4d3cdd455616a9c6cb0cff543de2b5fdc2766.zip
s3: Fix Coverity ID 709049 Dereference before null check
We have dereferenced fsp before. Because smb2 is only handle based, this is a bogus check. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104
-rw-r--r--source3/smbd/smb2_getinfo.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c
index 1e0f24cf75..076cc55f1a 100644
--- a/source3/smbd/smb2_getinfo.c
+++ b/source3/smbd/smb2_getinfo.c
@@ -316,7 +316,7 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx,
/* We know this name is ok, it's already passed the checks. */
- } else if (fsp && fsp->fh->fd == -1) {
+ } else if (fsp->fh->fd == -1) {
/*
* This is actually a QFILEINFO on a directory
* handle (returned from an NT SMB). NT5.0 seems