summaryrefslogtreecommitdiff
path: root/buildtools
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2011-02-23 10:20:15 +1100
committerAndrew Tridgell <tridge@samba.org>2011-02-23 01:29:38 +0100
commit5f6790bc74beab4ea9cd1de014ada21840cb8c3b (patch)
treef33bc850bd5492097628b7eec69ac35907f313b1 /buildtools
parent3b684824c1b7130b8723226e65fabaf5df47ca09 (diff)
downloadsamba-5f6790bc74beab4ea9cd1de014ada21840cb8c3b.tar.gz
samba-5f6790bc74beab4ea9cd1de014ada21840cb8c3b.tar.bz2
samba-5f6790bc74beab4ea9cd1de014ada21840cb8c3b.zip
build: duplicate symbols between system libraries aren't interesting
we expect dups in libpthread, libc and libattr Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Feb 23 01:29:38 CET 2011 on sn-devel-104
Diffstat (limited to 'buildtools')
-rw-r--r--buildtools/wafsamba/symbols.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/buildtools/wafsamba/symbols.py b/buildtools/wafsamba/symbols.py
index 4f4b30382b..0408d61b29 100644
--- a/buildtools/wafsamba/symbols.py
+++ b/buildtools/wafsamba/symbols.py
@@ -449,11 +449,21 @@ def symbols_dupcheck(task):
bld = task.env.bld
tgt_list = get_tgt_list(bld)
+ targets = LOCAL_CACHE(bld, 'TARGET_TYPE')
+
Logs.info("Checking for duplicate symbols")
for sym in bld.env.symbol_map:
subsystems = bld.env.symbol_map[sym]
if len(subsystems) == 1:
continue
+ # if all of them are in system libraries, we can ignore them. This copes
+ # with the duplication between libc, libpthread and libattr
+ all_syslib = True
+ for s in subsystems:
+ if s != 'c' and (not s in targets or targets[s] != 'SYSLIB'):
+ all_syslib = False
+ if all_syslib:
+ continue
Logs.info("symbol %s appears in %s" % (sym, subsystems))