ntdb: remove ntdb_error()

It was a hack to make compatibility easier.  Since we're not doing that,
it can go away: all callers must use the return value now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

1 files changed, 3 insertions, 3 deletions

diff --git a/lib/ntdb/check.c b/lib/ntdb/check.c
index 1c676c7d45..cff6e0345e 100644
--- a/lib/ntdb/check.c
+++ b/lib/ntdb/check.c
@@ -812,13 +812,13 @@ _PUBLIC_ enum NTDB_ERROR ntdb_check_(struct ntdb_context *ntdb,
 
 	ecode = ntdb_allrecord_lock(ntdb, F_RDLCK, NTDB_LOCK_WAIT, false);
 	if (ecode != NTDB_SUCCESS) {
-		return ntdb->last_error = ecode;
+		return ecode;
 	}
 
 	ecode = ntdb_lock_expand(ntdb, F_RDLCK);
 	if (ecode != NTDB_SUCCESS) {
 		ntdb_allrecord_unlock(ntdb, F_RDLCK);
-		return ntdb->last_error = ecode;
+		return ecode;
 	}
 
 	ecode = check_header(ntdb, &recovery, &features, &num_capabilities);
@@ -860,5 +860,5 @@ out:
 	ntdb_unlock_expand(ntdb, F_RDLCK);
 	free(fr);
 	free(used);
-	return ntdb->last_error = ecode;
+	return ecode;
 }