summaryrefslogtreecommitdiff
path: root/libcli
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2010-05-19 10:34:44 -0700
committerJeremy Allison <jra@samba.org>2010-05-19 10:36:39 -0700
commitb0d7a3d123cb96049dc782b317554448acdae1a2 (patch)
tree47cd4878580d27edbc85581794f10e1be78e1366 /libcli
parentac9341245af38fe019c43ad9e413dbc62e26bc7a (diff)
downloadsamba-b0d7a3d123cb96049dc782b317554448acdae1a2.tar.gz
samba-b0d7a3d123cb96049dc782b317554448acdae1a2.tar.bz2
samba-b0d7a3d123cb96049dc782b317554448acdae1a2.zip
Thanks to Andrew Bartlett's advice, fix the NTLMSSP version problem the correct way.
No more magic blobs :-). Use ndr_push_struct_blob() to push a properly formatted VERSION struct. Jeremy.
Diffstat (limited to 'libcli')
-rw-r--r--libcli/auth/msrpc_parse.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/libcli/auth/msrpc_parse.c b/libcli/auth/msrpc_parse.c
index 336611d132..7ac6fb57b2 100644
--- a/libcli/auth/msrpc_parse.c
+++ b/libcli/auth/msrpc_parse.c
@@ -174,7 +174,10 @@ bool msrpc_gen(TALLOC_CTX *mem_ctx,
break;
case 'b':
n = pointers[i].length;
- memcpy(blob->data + head_ofs, pointers[i].data, n);
+ if (pointers[i].data && n) {
+ /* don't follow null pointers... */
+ memcpy(blob->data + head_ofs, pointers[i].data, n);
+ }
head_ofs += n;
break;
case 'C':