diff options
| author | Andrew Tridgell <tridge@samba.org> | 2002-06-03 03:07:24 +0000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2002-06-03 03:07:24 +0000 |
| commit | 0bb6053946a1572a3496958e543d5c9ddf74120b (patch) | |
| tree | b176a0e6a348c2d58d7ba52405a484d1384a6bb9 /source3/CodingSuggestions | |
| parent | 9401cdbb514a65b96910117a5a850af0eef45dd7 (diff) | |
| download | samba-0bb6053946a1572a3496958e543d5c9ddf74120b.tar.gz samba-0bb6053946a1572a3496958e543d5c9ddf74120b.tar.bz2 samba-0bb6053946a1572a3496958e543d5c9ddf74120b.zip | |
put the ifdef for HAVE_VA_COPY in one place rather than in lots of
functions
(This used to be commit 1cf3228fdc20f0314d1f8e71ad710a5e548b3f72)
Diffstat (limited to 'source3/CodingSuggestions')
| -rw-r--r-- | source3/CodingSuggestions | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/CodingSuggestions b/source3/CodingSuggestions index 1ff3e01c1c..eda2bee6d0 100644 --- a/source3/CodingSuggestions +++ b/source3/CodingSuggestions @@ -59,8 +59,8 @@ Here are some other suggestions: 6) explicitly add const qualifiers on parm passing in functions where parm is input only (somewhat controversial but const can be #defined away) -7) when passing a va_list as an arg, or assigning one to another, check - for HAVE_VA_COPY, and use it if it exists. +7) when passing a va_list as an arg, or assigning one to another + please use the VA_COPY() macro reason: on some platforms, va_list is a struct that must be initialized in each function...can SEGV if you don't. |