diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2001-12-30 10:54:58 +0000 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2001-12-30 10:54:58 +0000 |
| commit | f6e6c678ad5338264496de43e9e1ab2fe4a28e64 (patch) | |
| tree | 21145aeb71e92fb12865142a70a1435a25100da5 /source3/auth/auth_unix.c | |
| parent | 3e10f9554ba0c3408be7ac859ec299394c2b0295 (diff) | |
| download | samba-f6e6c678ad5338264496de43e9e1ab2fe4a28e64.tar.gz samba-f6e6c678ad5338264496de43e9e1ab2fe4a28e64.tar.bz2 samba-f6e6c678ad5338264496de43e9e1ab2fe4a28e64.zip | |
Add a pile of doxygen style comments to various parts of Samba. Many of these
probably will never actually be genearted, but I like the style in any case.
Also fix a segfault in 'net rpc' when the login failed and a small memory leak
on failure in the auth_info.c code.
Andrew Bartlett
(This used to be commit 2efae7cc522651c22fb120835bc800645559b63e)
Diffstat (limited to 'source3/auth/auth_unix.c')
| -rw-r--r-- | source3/auth/auth_unix.c | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/source3/auth/auth_unix.c b/source3/auth/auth_unix.c index d134ce6909..2e753cb29c 100644 --- a/source3/auth/auth_unix.c +++ b/source3/auth/auth_unix.c @@ -21,11 +21,11 @@ #include "includes.h" -/**************************************************************************** -update the encrypted smbpasswd file from the plaintext username and password - -this ugly hack needs to die, but not quite yet... -*****************************************************************************/ +/** + * update the encrypted smbpasswd file from the plaintext username and password + * + * this ugly hack needs to die, but not quite yet, I think people still use it... + **/ static BOOL update_smbpassword_file(char *user, char *password) { SAM_ACCOUNT *sampass = NULL; @@ -77,10 +77,11 @@ static BOOL update_smbpassword_file(char *user, char *password) } -/**************************************************************************** -check if a username/password is OK assuming the password -in PLAIN TEXT -****************************************************************************/ +/** Check a plaintext username/password + * + * Cannot deal with an encrupted password in any manner whatsoever, + * unless the account has a null password. + **/ NTSTATUS check_unix_security(void *my_private_data, const auth_usersupplied_info *user_info, @@ -93,6 +94,9 @@ NTSTATUS check_unix_security(void *my_private_data, become_root(); pass = Get_Pwnam(user_info->internal_username.str); + + /** This call assumes a ASCII password, no charset transformation is + done. We may need to revisit this **/ nt_status = pass_check(pass, pass ? pass->pw_name : user_info->internal_username.str, (char *)user_info->plaintext_password.data, |