diff options
author | Andrew Bartlett <abartlet@samba.org> | 2002-05-22 12:44:45 +0000 |
---|---|---|
committer | Andrew Bartlett <abartlet@samba.org> | 2002-05-22 12:44:45 +0000 |
commit | b87eee983612c0d21b0c6f1346ba15ace797fe9e (patch) | |
tree | 24e2b36dfad85d014754e1ed08cb3d3b74704f24 /source3/lib/sysacls.c | |
parent | daec6cbbeee8401ef1aa0a3424ee05a3148d7ec8 (diff) | |
download | samba-b87eee983612c0d21b0c6f1346ba15ace797fe9e.tar.gz samba-b87eee983612c0d21b0c6f1346ba15ace797fe9e.tar.bz2 samba-b87eee983612c0d21b0c6f1346ba15ace797fe9e.zip |
Add a bit more const, and kill of (finally!) sys_getpwnam and sys_getpwuid.
These might be reimplmented as simple pass-through functions, but all users
really should be doing 'getpwnam_alloc' or 'getpwuid_alloc' to ensure that
there are not shared static buffers.
I don't beleive we actually need a getpw*() cache inside samba - if we do
then I think we should look at our code design first.
(some of these changes are for platforms I don't have access to, but
they look sane)
Andrew Bartlett
(This used to be commit 9d8431b04f41dceffe4c45cc969472ee59f7282f)
Diffstat (limited to 'source3/lib/sysacls.c')
-rw-r--r-- | source3/lib/sysacls.c | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/source3/lib/sysacls.c b/source3/lib/sysacls.c index 22245992f5..00d06e4a5a 100644 --- a/source3/lib/sysacls.c +++ b/source3/lib/sysacls.c @@ -644,13 +644,7 @@ char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p) break; case SMB_ACL_USER: - if ((pw = sys_getpwuid(ap->a_id)) == NULL) { - slprintf(idbuf, sizeof(idbuf)-1, "%ld", - (long)ap->a_id); - id = idbuf; - } else { - id = pw->pw_name; - } + id = uidtoname(ap->a_id); case SMB_ACL_USER_OBJ: tag = "user"; break; @@ -1281,13 +1275,7 @@ char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p) break; case SMB_ACL_USER: - if ((pw = sys_getpwuid(ap->a_id)) == NULL) { - slprintf(idbuf, sizeof(idbuf)-1, "%ld", - (long)ap->a_id); - id = idbuf; - } else { - id = pw->pw_name; - } + id = uidtoname(ap->a_id); case SMB_ACL_USER_OBJ: tag = "user"; break; |