summaryrefslogtreecommitdiff
path: root/source3/lib
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2003-02-13 04:46:55 +0000
committerMartin Pool <mbp@samba.org>2003-02-13 04:46:55 +0000
commit1f2a901d788f73d7f411129b59a261a5512b6b7d (patch)
tree5cf8b9c33aa56041f0a73c2bdf2e66696c96c2af /source3/lib
parent404a3f34c879f21bfef66f971d4ccb4c20e87f8e (diff)
downloadsamba-1f2a901d788f73d7f411129b59a261a5512b6b7d.tar.gz
samba-1f2a901d788f73d7f411129b59a261a5512b6b7d.tar.bz2
samba-1f2a901d788f73d7f411129b59a261a5512b6b7d.zip
Add FIXME about checking exit code for popen'd commands.
Fix typo. (This used to be commit 2b5664823e05e328c86051fb607182ad20d786d4)
Diffstat (limited to 'source3/lib')
-rw-r--r--source3/lib/util_file.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/lib/util_file.c b/source3/lib/util_file.c
index 611e0e40be..4babab8931 100644
--- a/source3/lib/util_file.c
+++ b/source3/lib/util_file.c
@@ -362,7 +362,7 @@ char *file_pload(char *syscmd, size_t *size)
while ((n = read(fd, buf, sizeof(buf))) > 0) {
tp = Realloc(p, total + n + 1);
if (!tp) {
- DEBUG(0,("file_pload: failed to exand buffer!\n"));
+ DEBUG(0,("file_pload: failed to expand buffer!\n"));
close(fd);
SAFE_FREE(p);
return NULL;
@@ -372,6 +372,9 @@ char *file_pload(char *syscmd, size_t *size)
}
if (p) p[total] = 0;
+ /* FIXME: Perhaps ought to check that the command completed
+ * successfully (returned 0); if not the data may be
+ * truncated. */
sys_pclose(fd);
if (size) *size = total;