summaryrefslogtreecommitdiff
path: root/source3/lib
diff options
context:
space:
mode:
authorLuke Leighton <lkcl@samba.org>1998-11-24 16:47:49 +0000
committerLuke Leighton <lkcl@samba.org>1998-11-24 16:47:49 +0000
commitced486c8415c7ece457edecb3246f7277a57d60b (patch)
tree578a345157409d97841c8c2c6fe2539226377c43 /source3/lib
parent0c9df3c61007eb170ae17282d7b31bea6899a656 (diff)
downloadsamba-ced486c8415c7ece457edecb3246f7277a57d60b.tar.gz
samba-ced486c8415c7ece457edecb3246f7277a57d60b.tar.bz2
samba-ced486c8415c7ece457edecb3246f7277a57d60b.zip
sorting out difference between aliases and groups in the cases where
unix groups are not explicitly mapped. i.e as a PDC or BDC you can have domain groups, as a member of a domain you cannot. as a member of a domain, unmapped unix groups are assumed to be aliases, and as a PDC or BDC, unmapped unix groups are assumed to be unix groups. there is _one_ other check needed with aliases to be added: unmapped unix groups that have the same name as an NT group on the PDC (for which i will need to write an LsaLookupNames call) should be assumed to be domain groups on the PDC. (This used to be commit 53b49b44e13a4ca9818ebc947372b1374831b568)
Diffstat (limited to 'source3/lib')
-rw-r--r--source3/lib/util_sid.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/lib/util_sid.c b/source3/lib/util_sid.c
index cce360f4c1..a483f85b84 100644
--- a/source3/lib/util_sid.c
+++ b/source3/lib/util_sid.c
@@ -134,7 +134,10 @@ BOOL sid_split_rid(DOM_SID *sid, uint32 *rid)
if (sid->num_auths > 0)
{
sid->num_auths--;
- (*rid) = sid->sub_auths[sid->num_auths];
+ if (rid != NULL)
+ {
+ (*rid) = sid->sub_auths[sid->num_auths];
+ }
return True;
}
return False;