diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-08-28 09:19:30 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:38:57 -0500 |
| commit | c52b3fb89f29110d2c2026a540e5dd39826bb799 (patch) | |
| tree | c78a8876d311a2696627a4b910b58501c5e358e6 /source3/libsmb/namequery_dc.c | |
| parent | e09daab0157e1c9fc9ab29627f9ca612456eed8c (diff) | |
| download | samba-c52b3fb89f29110d2c2026a540e5dd39826bb799.tar.gz samba-c52b3fb89f29110d2c2026a540e5dd39826bb799.tar.bz2 samba-c52b3fb89f29110d2c2026a540e5dd39826bb799.zip | |
r17881: Another microstep towards better error reporting: Make get_sorted_dc_list
return NTSTATUS.
If we want to differentiate different name resolution problems we might want
to introduce yet another error class for Samba-internal errors. Things like no
route to host to the WINS server, a DNS server explicitly said host not found
etc might be worth passing up.
Because we can not stash everything into the existing NT_STATUS codes, what
about a Samba-specific error class like NT_STATUS_DOS and NT_STATUS_LDAP?
Volker
(This used to be commit 60a166f0347170dff38554bed46193ce1226c8c1)
Diffstat (limited to 'source3/libsmb/namequery_dc.c')
| -rw-r--r-- | source3/libsmb/namequery_dc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/libsmb/namequery_dc.c b/source3/libsmb/namequery_dc.c index b9a593bf2a..4afd04a98f 100644 --- a/source3/libsmb/namequery_dc.c +++ b/source3/libsmb/namequery_dc.c @@ -81,7 +81,8 @@ static BOOL rpc_dc_name(const char *domain, fstring srv_name, struct in_addr *ip /* get a list of all domain controllers */ - if ( !get_sorted_dc_list(domain, &ip_list, &count, False) ) { + if (!NT_STATUS_IS_OK(get_sorted_dc_list(domain, &ip_list, &count, + False))) { DEBUG(3, ("Could not look up dc's for domain %s\n", domain)); return False; } |