summaryrefslogtreecommitdiff
path: root/source3/libsmb
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2003-09-04 01:12:39 +0000
committerJeremy Allison <jra@samba.org>2003-09-04 01:12:39 +0000
commit245fbf7efbc42530c81d5aac66681bb892c97557 (patch)
tree6e4a7e8bd5e5d66336e7f3689a62812322053103 /source3/libsmb
parent7da5c6a0e719470e234ad6597ba33c9667786ab2 (diff)
downloadsamba-245fbf7efbc42530c81d5aac66681bb892c97557.tar.gz
samba-245fbf7efbc42530c81d5aac66681bb892c97557.tar.bz2
samba-245fbf7efbc42530c81d5aac66681bb892c97557.zip
Used cachegrind to track down some bottlenecks.
Removed calls to clobber_region when not compiling with developer as they were hiding speed problems. Added fast path to convert_string() when dealing with ascii -> ascii, ucs2-le to ascii and ascii to ucs2-le with values <= 0x7F. This gives a speedup of 22% on my nbench tests. Next I will do this on convert_string_allocate. Jeremy. (This used to be commit ef140d15ea0d76a3e7cdcadbfd3e917c210a9411)
Diffstat (limited to 'source3/libsmb')
-rw-r--r--source3/libsmb/clientgen.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/source3/libsmb/clientgen.c b/source3/libsmb/clientgen.c
index 308ce31fd0..0a134f715d 100644
--- a/source3/libsmb/clientgen.c
+++ b/source3/libsmb/clientgen.c
@@ -299,9 +299,12 @@ struct cli_state *cli_initialise(struct cli_state *cli)
memset(cli->outbuf, 0, cli->bufsize);
memset(cli->inbuf, 0, cli->bufsize);
+
+#if defined(DEVELOPER)
/* just because we over-allocate, doesn't mean it's right to use it */
clobber_region(FUNCTION_MACRO, __LINE__, cli->outbuf+cli->bufsize, SAFETY_MARGIN);
clobber_region(FUNCTION_MACRO, __LINE__, cli->inbuf+cli->bufsize, SAFETY_MARGIN);
+#endif
/* initialise signing */
cli_null_set_signing(cli);