The function add_name_to_subnet(), in file nmbd_namelistdb.c, returns a

pointer to the newly constructed name list entry.  In most cases, this
return value is ignored.  The two exceptions are in asyncdns.c and
nmbd_winsproxy.c.

Most of the calls which ignored the return value were not cast to void, so
I added the cast.  This helped me sort out which calls really did use the
return value.  I also discovered one case, in nmbd_winsserver.c, in which
the return value was being stored to a variable which, in turn, was not
used.

Chris -)-----
(This used to be commit 384122d165ed6d5d211a29e5a63a63bf5cd82c75)

1 files changed, 2 insertions, 2 deletions

diff --git a/source3/nmbd/nmbd_namelistdb.c b/source3/nmbd/nmbd_namelistdb.c
index 4454cdfed0..d2c9ea2e71 100644
--- a/source3/nmbd/nmbd_namelistdb.c
+++ b/source3/nmbd/nmbd_namelistdb.c
@@ -280,8 +280,8 @@ void standard_success_register(struct subnet_record *subrec,
 
   namerec = find_name_on_subnet( subrec, nmbname, FIND_SELF_NAME );
   if( NULL == namerec )
-    add_name_to_subnet( subrec, nmbname->name, nmbname->name_type,
-                        nb_flags, ttl, SELF_NAME, 1, &registered_ip );
+    (void)add_name_to_subnet( subrec, nmbname->name, nmbname->name_type,
+                              nb_flags, ttl, SELF_NAME, 1, &registered_ip );
   else
     update_name_ttl( namerec, ttl );
 }