diff options
| author | Simo Sorce <idra@samba.org> | 2003-06-22 10:09:52 +0000 |
|---|---|---|
| committer | Simo Sorce <idra@samba.org> | 2003-06-22 10:09:52 +0000 |
| commit | f5974dfaae680d98b78d600cd1f1aaece332a085 (patch) | |
| tree | bd24ad803125c21cdb82a27d051e0029cb21ad65 /source3/nsswitch/winbindd_passdb.c | |
| parent | 4830a878455fe0e525aa3bd2a59e55d1f30bddad (diff) | |
| download | samba-f5974dfaae680d98b78d600cd1f1aaece332a085.tar.gz samba-f5974dfaae680d98b78d600cd1f1aaece332a085.tar.bz2 samba-f5974dfaae680d98b78d600cd1f1aaece332a085.zip | |
Found out a good number of NT_STATUS_IS_ERR used the wrong way.
As abartlet rememberd me NT_STATUS_IS_ERR != !NT_STATUS_IS_OK
This patch will cure the problem.
Working on this one I found 16 functions where I think NT_STATUS_IS_ERR() is
used correctly, but I'm not 100% sure, coders should check the use of
NT_STATUS_IS_ERR() in samba is ok now.
Simo.
(This used to be commit c501e84d412563eb3f674f76038ec48c2b458687)
Diffstat (limited to 'source3/nsswitch/winbindd_passdb.c')
| -rw-r--r-- | source3/nsswitch/winbindd_passdb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/source3/nsswitch/winbindd_passdb.c b/source3/nsswitch/winbindd_passdb.c index 503b97899c..401662b6a7 100644 --- a/source3/nsswitch/winbindd_passdb.c +++ b/source3/nsswitch/winbindd_passdb.c @@ -41,7 +41,7 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain, DEBUG(3,("pdb: query_user_list\n")); - if (NT_STATUS_IS_ERR(result = pdb_init_sam(&sam_account))) { + if (!NT_STATUS_IS_OK(result = pdb_init_sam(&sam_account))) { return result; } @@ -84,7 +84,7 @@ static NTSTATUS query_user_list(struct winbindd_domain *domain, i++; - if (NT_STATUS_IS_ERR(pdb_reset_sam(sam_account))) { + if (!NT_STATUS_IS_OK(pdb_reset_sam(sam_account))) { result = NT_STATUS_UNSUCCESSFUL; break; } @@ -177,7 +177,7 @@ static NTSTATUS sid_to_name(struct winbindd_domain *domain, if (NT_STATUS_IS_OK(sid_to_uid(sid, &id))) { /* this is a user */ - if (NT_STATUS_IS_ERR(result = pdb_init_sam(&sam_account))) { + if (!NT_STATUS_IS_OK(result = pdb_init_sam(&sam_account))) { return result; } @@ -217,7 +217,7 @@ static NTSTATUS query_user(struct winbindd_domain *domain, DEBUG(3,("pdb: query_user sid=%s\n", sid_string_static(user_sid))); - if (NT_STATUS_IS_ERR(result = pdb_init_sam(&sam_account))) { + if (!NT_STATUS_IS_OK(result = pdb_init_sam(&sam_account))) { return result; } |