summaryrefslogtreecommitdiff
path: root/source3/nsswitch
diff options
context:
space:
mode:
authorGünther Deschner <gd@samba.org>2008-08-19 10:59:18 +0200
committerGünther Deschner <gd@samba.org>2008-10-10 15:38:21 +0200
commit0566164db03a19b98d4aec5cca63ece2a01acbec (patch)
tree2cf56e81b500ef49dffaa690772362fad3a0ffb2 /source3/nsswitch
parent0532291fe9650f968aab0fb6b60e08f41b334c24 (diff)
downloadsamba-0566164db03a19b98d4aec5cca63ece2a01acbec.tar.gz
samba-0566164db03a19b98d4aec5cca63ece2a01acbec.tar.bz2
samba-0566164db03a19b98d4aec5cca63ece2a01acbec.zip
pam_winbind: add wbc_auth_error_to_pam_error().
Guenther
Diffstat (limited to 'source3/nsswitch')
-rw-r--r--source3/nsswitch/pam_winbind.c53
1 files changed, 45 insertions, 8 deletions
diff --git a/source3/nsswitch/pam_winbind.c b/source3/nsswitch/pam_winbind.c
index e8f2459568..c840bba9d4 100644
--- a/source3/nsswitch/pam_winbind.c
+++ b/source3/nsswitch/pam_winbind.c
@@ -749,15 +749,9 @@ static int pam_winbind_request(struct pwb_context *ctx,
}
static int pam_winbind_request_log(struct pwb_context *ctx,
- enum winbindd_cmd req_type,
- struct winbindd_request *request,
- struct winbindd_response *response,
+ int retval,
const char *user)
{
- int retval;
-
- retval = pam_winbind_request(ctx, req_type, request, response);
-
switch (retval) {
case PAM_AUTH_ERR:
/* incorrect password */
@@ -789,6 +783,7 @@ static int pam_winbind_request_log(struct pwb_context *ctx,
return retval;
case PAM_SUCCESS:
/* Otherwise, the authentication looked good */
+#if 0
switch (req_type) {
case WINBINDD_INFO:
break;
@@ -805,7 +800,7 @@ static int pam_winbind_request_log(struct pwb_context *ctx,
"user '%s' OK", user);
break;
}
-
+#endif
return retval;
default:
/* we don't know anything about this return value */
@@ -816,6 +811,48 @@ static int pam_winbind_request_log(struct pwb_context *ctx,
}
}
+static int wbc_auth_error_to_pam_error(struct pwb_context *ctx,
+ struct wbcAuthErrorInfo *e,
+ wbcErr status,
+ const char *username,
+ const char *fn)
+{
+ int ret = PAM_AUTH_ERR;
+
+ if (WBC_ERROR_IS_OK(status)) {
+ _pam_log_debug(ctx, LOG_DEBUG, "request %s succeeded",
+ fn);
+ ret = PAM_SUCCESS;
+ return pam_winbind_request_log(ctx, ret, username);
+ }
+
+ if (e) {
+ if (e->pam_error != PAM_SUCCESS) {
+ _pam_log(ctx, LOG_ERR,
+ "request %s failed: %s, "
+ "PAM error: %s (%d), NTSTATUS: %s, "
+ "Error message was: %s",
+ fn,
+ wbcErrorString(status),
+ _pam_error_code_str(e->pam_error),
+ e->pam_error,
+ e->nt_string,
+ e->display_string);
+ ret = e->pam_error;
+ return pam_winbind_request_log(ctx, ret, username);
+ }
+
+ _pam_log(ctx, LOG_ERR, "request %s failed, but PAM error 0!", fn);
+
+ ret = PAM_SERVICE_ERR;
+ return pam_winbind_request_log(ctx, ret, username);
+ }
+
+ ret = wbc_error_to_pam_error(status);
+ return pam_winbind_request_log(ctx, ret, username);
+}
+
+
/**
* send a password expiry message if required
*