diff options
author | Volker Lendecke <vl@samba.org> | 2012-01-06 17:19:54 +0100 |
---|---|---|
committer | Volker Lendecke <vlendec@samba.org> | 2012-01-18 14:48:04 +0100 |
commit | 45e61fcf61ed9863fbe2b116fe0763fc139bbe0d (patch) | |
tree | 06ea9ead2285b4a671d102edb8824422f7325703 /source3/passdb/account_pol.c | |
parent | e75c436fe6a9ee44f6adc744b6269e99f4920431 (diff) | |
download | samba-45e61fcf61ed9863fbe2b116fe0763fc139bbe0d.tar.gz samba-45e61fcf61ed9863fbe2b116fe0763fc139bbe0d.tar.bz2 samba-45e61fcf61ed9863fbe2b116fe0763fc139bbe0d.zip |
s3: Add a "lock_order" argument to db_open
This will be used to enforce a lock hierarchy between the databases. We have
seen deadlocks between locking.tdb, brlock.tdb, serverid.tdb and notify*.tdb.
These should be fixed by refusing a dbwrap_fetch_locked that does not follow a
defined lock hierarchy.
Diffstat (limited to 'source3/passdb/account_pol.c')
-rw-r--r-- | source3/passdb/account_pol.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/source3/passdb/account_pol.c b/source3/passdb/account_pol.c index a32d07517d..4cb185c494 100644 --- a/source3/passdb/account_pol.c +++ b/source3/passdb/account_pol.c @@ -220,12 +220,13 @@ bool init_account_policy(void) } db = db_open(NULL, state_path("account_policy.tdb"), 0, TDB_DEFAULT, - O_RDWR, 0600); + O_RDWR, 0600, DBWRAP_LOCK_ORDER_1); if (db == NULL) { /* the account policies files does not exist or open * failed, try to create a new one */ db = db_open(NULL, state_path("account_policy.tdb"), 0, - TDB_DEFAULT, O_RDWR|O_CREAT, 0600); + TDB_DEFAULT, O_RDWR|O_CREAT, 0600, + DBWRAP_LOCK_ORDER_1); if (db == NULL) { DEBUG(0,("Failed to open account policy database\n")); return False; |