diff options
| author | Jeremy Allison <jra@samba.org> | 2005-08-11 20:44:18 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:00:28 -0500 |
| commit | 4ae6b9765f5a60e22bb4dc00d328b3d739941aba (patch) | |
| tree | 482af38eb3da7f5af821486ecd53dc83e12d4b10 /source3/printing | |
| parent | d6403e7280530ed66aa9f5d97ca225afb7130484 (diff) | |
| download | samba-4ae6b9765f5a60e22bb4dc00d328b3d739941aba.tar.gz samba-4ae6b9765f5a60e22bb4dc00d328b3d739941aba.tar.bz2 samba-4ae6b9765f5a60e22bb4dc00d328b3d739941aba.zip | |
r9244: Fix bugs found by Coverity.
Jeremy.
(This used to be commit bf80edeea70cb4ed90f9e1e7adeedeb9cf3b38c1)
Diffstat (limited to 'source3/printing')
| -rw-r--r-- | source3/printing/printing.c | 24 |
1 files changed, 21 insertions, 3 deletions
diff --git a/source3/printing/printing.c b/source3/printing/printing.c index 2a7cd5d3a7..52a3070466 100644 --- a/source3/printing/printing.c +++ b/source3/printing/printing.c @@ -399,8 +399,10 @@ uint32 sysjob_to_jobid(int unix_jobid) if (!lp_print_ok(snum)) continue; pdb = get_print_db_byname(lp_const_servicename(snum)); - if (pdb) - tdb_traverse(pdb->tdb, unixjob_traverse_fn, &unix_jobid); + if (!pdb) { + continue; + } + tdb_traverse(pdb->tdb, unixjob_traverse_fn, &unix_jobid); release_print_db(pdb); if (sysjob_to_jobid_value != (uint32)-1) return sysjob_to_jobid_value; @@ -1067,6 +1069,10 @@ static void print_queue_update_internal( const char *sharename, TDB_DATA jcdata; fstring keystr, cachestr; struct tdb_print_db *pdb = get_print_db_byname(sharename); + + if (!pdb) { + return; + } DEBUG(5,("print_queue_update_internal: printer = %s, type = %d, lpq command = [%s]\n", sharename, current_printif->type, lpq_command)); @@ -1426,6 +1432,11 @@ static void print_queue_update(int snum, BOOL force) sent. */ pdb = get_print_db_byname(sharename); + if (!pdb) { + SAFE_FREE(buffer); + return; + } + snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename); if ( !tdb_store_uint32( pdb->tdb, key, time(NULL) ) ) { @@ -1731,6 +1742,10 @@ static BOOL remove_from_jobs_changed(const char* sharename, uint32 jobid) BOOL ret = False; BOOL gotlock = False; + if (!pdb) { + return False; + } + ZERO_STRUCT(data); key = string_tdb_data("INFO/jobs_changed"); @@ -2057,11 +2072,14 @@ static int get_queue_status(const char* sharename, print_status_struct *status) struct tdb_print_db *pdb = get_print_db_byname(sharename); int len; + if (status) { + ZERO_STRUCTP(status); + } + if (!pdb) return 0; if (status) { - ZERO_STRUCTP(status); fstr_sprintf(keystr, "STATUS/%s", sharename); data = tdb_fetch(pdb->tdb, string_tdb_data(keystr)); if (data.dptr) { |