diff options
| author | Jeremy Allison <jra@samba.org> | 2000-12-15 21:29:06 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2000-12-15 21:29:06 +0000 |
| commit | 99c2693c620cd222da5561d526aa328bec426b77 (patch) | |
| tree | 5f524e8a0a8fa929953df69357195ffaf83b68af /source3/rpc_client/cli_srvsvc.c | |
| parent | 89af6fd745a6f49668bae5b5c2d239d3671fb299 (diff) | |
| download | samba-99c2693c620cd222da5561d526aa328bec426b77.tar.gz samba-99c2693c620cd222da5561d526aa328bec426b77.tar.bz2 samba-99c2693c620cd222da5561d526aa328bec426b77.zip | |
Added lock backouts on fail.
When chaining together long lines of bloody "if" statements, which should
logically be separated, and one of them allocates memory, remember to
*free* it *WHETHER OR NOT THE IF STATEMENTS SUCCEEDED* !!!!
Yes I do consider this a bug in the coding style of Tridge, Rusty, Tim et al. :-).
I'm just pissed 'cos this took 4 hours to track down even with an insure error report
stating me in the face and also Ben Woodward looking over the code with me :-).
Jeremy.
(This used to be commit 506b5e34c3ba16768dbc82ba21044787de160c45)
Diffstat (limited to 'source3/rpc_client/cli_srvsvc.c')
| -rw-r--r-- | source3/rpc_client/cli_srvsvc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/source3/rpc_client/cli_srvsvc.c b/source3/rpc_client/cli_srvsvc.c index b6dc0aff4a..4a3aed6d15 100644 --- a/source3/rpc_client/cli_srvsvc.c +++ b/source3/rpc_client/cli_srvsvc.c @@ -243,7 +243,6 @@ BOOL do_srv_net_srv_share_enum(struct cli_state *cli, /* report error code */ DEBUG(0,("SRV_R_NET_SHARE_ENUM: %s\n", get_nt_error_msg(r_o->status))); prs_mem_free(&rdata); - free_srv_r_net_share_enum(r_o); return False; } @@ -252,7 +251,6 @@ BOOL do_srv_net_srv_share_enum(struct cli_state *cli, DEBUG(0,("SRV_R_NET_SHARE_ENUM: info class %d does not match request %d\n", r_o->ctr.switch_value, switch_value)); prs_mem_free(&rdata); - free_srv_r_net_share_enum(r_o); return False; } |