Changing drivers using the properties page works - but only if getting/setting

security descriptors is disabled (as it is in this code).

If get/set sd's is enabled spooler.exe crashes on NT.

I'll investigate and fix that issue next.

Jeremy.
(This used to be commit 8c9ed874363e6a710bc0fe521bb8c4f7ee219587)

1 files changed, 2 insertions, 3 deletions

diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index 86fee3017f..7e01a379db 100644
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -1420,8 +1420,7 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
 		if(!prs_uint16("leading zero", ps, depth, &zero))
 			return False;
 
-		do
-		{	
+		while (p && (*p!=0)) {	
 			while (*q!=0)
 				q++;
 
@@ -1437,7 +1436,7 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
 			q++;
 			p=q;
 
-		} while (*p!=0); /* end on the last leading 0 */
+		}
 		
 		prs_set_offset(ps, struct_offset);