summaryrefslogtreecommitdiff
path: root/source3/rpc_server
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2010-07-12 14:26:34 +1000
committerAndrew Tridgell <tridge@samba.org>2010-07-14 16:22:49 +1000
commit0d95cee58f80e46636fa4b826d248c9ce9983c9b (patch)
tree8d48702186666fc8a27cb21685c61870fa95d4c5 /source3/rpc_server
parent1debe30689e75023fab44028ef6942a692e37e95 (diff)
downloadsamba-0d95cee58f80e46636fa4b826d248c9ce9983c9b.tar.gz
samba-0d95cee58f80e46636fa4b826d248c9ce9983c9b.tar.bz2
samba-0d95cee58f80e46636fa4b826d248c9ce9983c9b.zip
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
This fixes a bug where register_existing_vuid() could be called with a NULL server_info if the alloction failed. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
Diffstat (limited to 'source3/rpc_server')
-rw-r--r--source3/rpc_server/srv_pipe.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/source3/rpc_server/srv_pipe.c b/source3/rpc_server/srv_pipe.c
index 34587f8964..85c212aa93 100644
--- a/source3/rpc_server/srv_pipe.c
+++ b/source3/rpc_server/srv_pipe.c
@@ -736,9 +736,10 @@ static bool pipe_ntlmssp_verify_final(pipes_struct *p, DATA_BLOB *p_resp_blob)
TALLOC_FREE(p->server_info);
- p->server_info = auth_ntlmssp_server_info(p, a);
- if (p->server_info == NULL) {
- DEBUG(0, ("auth_ntlmssp_server_info failed to obtain the server info for authenticated user\n"));
+ status = auth_ntlmssp_server_info(p, a, &p->server_info);
+ if (!NT_STATUS_IS_OK(status)) {
+ DEBUG(0, ("auth_ntlmssp_server_info failed to obtain the server info for authenticated user: %s\n",
+ nt_errstr(status)));
return false;
}