summaryrefslogtreecommitdiff
path: root/source3/rpcclient
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2003-02-18 07:05:02 +0000
committerMartin Pool <mbp@samba.org>2003-02-18 07:05:02 +0000
commit188c5195ede9825f30845f4aab549390ac67887e (patch)
tree160661e5ac294c78623bab30d9c89241096ac71b /source3/rpcclient
parent059c4fd81db2b50cd9748577bd1d84e2acd9c330 (diff)
downloadsamba-188c5195ede9825f30845f4aab549390ac67887e.tar.gz
samba-188c5195ede9825f30845f4aab549390ac67887e.tar.bz2
samba-188c5195ede9825f30845f4aab549390ac67887e.zip
Check return code of string_to_sid. (Merge from HEAD)
(This used to be commit 5d09aea6f78aa247dbd77617c93c2a1dd2e2702f)
Diffstat (limited to 'source3/rpcclient')
-rw-r--r--source3/rpcclient/cmd_lsarpc.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/source3/rpcclient/cmd_lsarpc.c b/source3/rpcclient/cmd_lsarpc.c
index 8afeb8e83b..57ec09ef63 100644
--- a/source3/rpcclient/cmd_lsarpc.c
+++ b/source3/rpcclient/cmd_lsarpc.c
@@ -210,8 +210,11 @@ static NTSTATUS cmd_lsa_lookup_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx,
goto done;
}
- for (i = 0; i < argc - 1; i++)
- string_to_sid(&sids[i], argv[i + 1]);
+ for (i = 0; i < argc - 1; i++)
+ if (!string_to_sid(&sids[i], argv[i + 1])) {
+ result = NT_STATUS_INVALID_SID;
+ goto done;
+ }
/* Lookup the SIDs */