diff options
| author | Volker Lendecke <vlendec@samba.org> | 2007-01-02 12:10:46 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 12:16:51 -0500 |
| commit | 2c1b3a072061d40f112c3f1112fd9ae08b6038e4 (patch) | |
| tree | f6c1a43969289dd959aa49e058de0adb154d4f75 /source3/smbd/reply.c | |
| parent | 3c4342ddfbe95cfbc64902177d4955882f71a4a0 (diff) | |
| download | samba-2c1b3a072061d40f112c3f1112fd9ae08b6038e4.tar.gz samba-2c1b3a072061d40f112c3f1112fd9ae08b6038e4.tar.bz2 samba-2c1b3a072061d40f112c3f1112fd9ae08b6038e4.zip | |
r20470: Jeremy, another one to check:
The only error path of can_delete() that we're interested in ntcreate&x is the
one of can_delete_file_in_directory(), so call that directly.
The only other one where we might get a NT_STATUS_ACCESS_DENIED is from the
lstat in can_delete, but this is covered later in the open_directory and
open_file_ntcreate calls. open_directory does a stat() in the open case which
also covers the (potential) symlink, and open_file_ntcreate does the open(2)
itself, so this should also work.
This makes can_delete() static to reply.c.
Volker
(This used to be commit d289037fdbc8bd3e0723784888946d5b39ffadef)
Diffstat (limited to 'source3/smbd/reply.c')
| -rw-r--r-- | source3/smbd/reply.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index e29ecab8ba..607c12f8b1 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -1888,7 +1888,9 @@ static NTSTATUS can_rename(connection_struct *conn, char *fname, uint16 dirtype, Check if a user is allowed to delete a file. ********************************************************************/ -NTSTATUS can_delete(connection_struct *conn, char *fname, uint32 dirtype, BOOL bad_path, BOOL check_is_at_open) +static NTSTATUS can_delete(connection_struct *conn, char *fname, + uint32 dirtype, BOOL bad_path, + BOOL check_is_at_open) { SMB_STRUCT_STAT sbuf; uint32 fattr; |