summaryrefslogtreecommitdiff
path: root/source3/smbd
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2012-06-27 15:33:43 +0200
committerStefan Metzmacher <metze@samba.org>2012-06-29 00:14:54 +0200
commit82dc0b33b9af5094d78f3ecd855900e49c580343 (patch)
tree90e0a241c4c9f27afd676b56b4b51f5ca19a706a /source3/smbd
parentee8ae459aea6879377b5510851a6dc673cf72aad (diff)
downloadsamba-82dc0b33b9af5094d78f3ecd855900e49c580343.tar.gz
samba-82dc0b33b9af5094d78f3ecd855900e49c580343.tar.bz2
samba-82dc0b33b9af5094d78f3ecd855900e49c580343.zip
s3:smb2_server: make sure sequence numbers don't wrap at UINT64_MAX
metze
Diffstat (limited to 'source3/smbd')
-rw-r--r--source3/smbd/smb2_server.c19
1 files changed, 17 insertions, 2 deletions
diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 320923a4cf..b01d01f8d5 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -570,11 +570,26 @@ static void smb2_set_operation_credit(struct smbd_server_connection *sconn,
}
/*
- * remove the range we'll already granted to the client
+ * sequence numbers should not wrap
+ *
+ * 1. calculate the possible credits until
+ * the sequence numbers start to wrap on 64-bit.
+ *
+ * 2. UINT64_MAX is used for Break Notifications.
+ *
+ * 2. truncate the possible credits to the maximum
+ * credits we want to grant to the client in total.
+ *
+ * 3. remove the range we'll already granted to the client
* this makes sure the client consumes the lowest sequence
* number, before we can grant additional credits.
*/
- credits_possible = sconn->smb2.max_credits;
+ credits_possible = UINT64_MAX - sconn->smb2.seqnum_low;
+ if (credits_possible > 0) {
+ /* remove UINT64_MAX */
+ credits_possible -= 1;
+ }
+ credits_possible = MIN(credits_possible, sconn->smb2.max_credits);
credits_possible -= sconn->smb2.seqnum_range;
credits_granted = MIN(credits_granted, credits_possible);