diff options
| author | Andrew Tridgell <tridge@samba.org> | 1998-11-09 03:45:49 +0000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 1998-11-09 03:45:49 +0000 |
| commit | 8c62b28e0ef1e012ebb0713701916d82ffc7661e (patch) | |
| tree | 61b04267c035e1ef2d53f275dd5bbb2fbbb7f7ba /source3/smbd | |
| parent | 548b417d404a2653ebb5918b0c169ccdfafe856f (diff) | |
| download | samba-8c62b28e0ef1e012ebb0713701916d82ffc7661e.tar.gz samba-8c62b28e0ef1e012ebb0713701916d82ffc7661e.tar.bz2 samba-8c62b28e0ef1e012ebb0713701916d82ffc7661e.zip | |
converted smbclient to use clientgen.c rather than clientutil.c
I did this when I saw yet another bug report complaining about
smbclient intermittently missing files. Rather than applying more
patches to smbclient it was better to move to the more robust
clientgen.c code.
The conversion wasn't perfect, I probably lost some features of
smbclient while doing it, but at least smbclient should be consistent
now. It if fails it should _always_ fail rather than giving people the
false impression of a reliable utility.
the tar stuff seems to work, but hasn't had much testing as I never
use it myself. I'm sure someone will find bugs in my conversion of
smbtar.c. It was quite tricky as it did a lot of its own SMB calls. It
now uses clientgen.c exclusively.
smbclient is still quite messy, but at least it doesn't build its own
SMB packets.
I haven't touched smbmount as I never use it. Mike, do you want to
convert smbmount to use clientgen.c?
(This used to be commit e14ca7765ace1b721dad8eca4a527a4e4a8f1ab8)
Diffstat (limited to 'source3/smbd')
| -rw-r--r-- | source3/smbd/dfree.c | 2 | ||||
| -rw-r--r-- | source3/smbd/password.c | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/source3/smbd/dfree.c b/source3/smbd/dfree.c index 020386645c..8cba8d0644 100644 --- a/source3/smbd/dfree.c +++ b/source3/smbd/dfree.c @@ -205,7 +205,7 @@ static SMB_BIG_UINT disk_free(char *path,SMB_BIG_UINT *bsize,SMB_BIG_UINT *dfree /* FIXME : Any reason for this assumption ? */ if (*bsize < 256) { - DEBUG(5,("disk_free:Warning: bsize == %d < 256 . Changing to assumed correct bsize = 512\n",*bsize)); + DEBUG(5,("disk_free:Warning: bsize == %d < 256 . Changing to assumed correct bsize = 512\n",(int)*bsize)); *bsize = 512; } diff --git a/source3/smbd/password.c b/source3/smbd/password.c index d49ea7c562..fb5acf156f 100644 --- a/source3/smbd/password.c +++ b/source3/smbd/password.c @@ -1037,7 +1037,6 @@ BOOL server_validate(char *user, char *domain, char *ntpass, int ntpasslen) { struct cli_state *cli; - extern fstring local_machine; static unsigned char badpass[24]; static BOOL tested_password_server = False; static BOOL bad_password_server = False; |