diff options
| author | Jeremy Allison <jra@samba.org> | 2012-08-08 15:35:28 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2012-08-09 12:06:54 -0700 |
| commit | 526e875cec15761099438e17df3f56bc2bd5b761 (patch) | |
| tree | 8ad776c58b3a25b8739b03cdaf330c295bc570b7 /source3/utils/net_registry_check.c | |
| parent | e1ec86a49ce1d7c3ebe99fc175ffad70a03c4a0b (diff) | |
| download | samba-526e875cec15761099438e17df3f56bc2bd5b761.tar.gz samba-526e875cec15761099438e17df3f56bc2bd5b761.tar.bz2 samba-526e875cec15761099438e17df3f56bc2bd5b761.zip | |
Check error returns from strupper_m() (in all reasonable places).
Diffstat (limited to 'source3/utils/net_registry_check.c')
| -rw-r--r-- | source3/utils/net_registry_check.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/source3/utils/net_registry_check.c b/source3/utils/net_registry_check.c index 872aa5a371..45a01f20f5 100644 --- a/source3/utils/net_registry_check.c +++ b/source3/utils/net_registry_check.c @@ -419,7 +419,10 @@ static bool read_info(struct check_ctx *ctx, const char *key, TDB_DATA val) static bool is_all_upper(const char *str) { bool ret; char *tmp = talloc_strdup(talloc_tos(), str); - strupper_m(tmp); + if (!strupper_m(tmp)) { + talloc_free(tmp); + return false; + } ret = (strcmp(tmp, str) == 0); talloc_free(tmp); return ret; @@ -698,7 +701,10 @@ static bool normalize_path_internal(char* path, char sep) { } *optr = '\0'; - strupper_m(path); + if (!strupper_m(path)) { + talloc_free(discard_const(orig)); + return false; + } changed = (strcmp(orig, path) != 0); talloc_free(discard_const(orig)); return changed; |