diff options
| author | Volker Lendecke <vlendec@samba.org> | 2006-06-19 19:07:39 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:18:48 -0500 |
| commit | e7fc37cf0f4bd2c0f25865fb07d1bff27b239130 (patch) | |
| tree | 05321a37f1ad2b6082ee1f84beeb1fbe589fe519 /source3/utils/net_usershare.c | |
| parent | 5c822ecc495bbac95704378c6e09885255076cbe (diff) | |
| download | samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.tar.gz samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.tar.bz2 samba-e7fc37cf0f4bd2c0f25865fb07d1bff27b239130.zip | |
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit 3df0bf7d6050fd7c9ace72487d4f74d92e30a584)
Diffstat (limited to 'source3/utils/net_usershare.c')
| -rw-r--r-- | source3/utils/net_usershare.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/source3/utils/net_usershare.c b/source3/utils/net_usershare.c index 253416c5cb..09ef8bd97f 100644 --- a/source3/utils/net_usershare.c +++ b/source3/utils/net_usershare.c @@ -147,7 +147,10 @@ static int net_usershare_delete(int argc, const char **argv) return net_usershare_delete_usage(argc, argv); } - sharename = strdup_lower(argv[0]); + if ((sharename = strdup_lower(argv[0])) == NULL) { + d_fprintf(stderr, "strdup failed\n"); + return -1; + } if (!validate_net_name(sharename, INVALID_SHARENAME_CHARS, strlen(sharename))) { d_fprintf(stderr, "net usershare delete: share name %s contains " @@ -641,7 +644,12 @@ static int net_usershare_add(int argc, const char **argv) } /* Get the name */ - name = talloc_strndup(ctx, pacl, pcolon - pacl); + if ((name = talloc_strndup(ctx, pacl, pcolon - pacl)) == NULL) { + d_fprintf(stderr, "talloc_strndup failed\n"); + talloc_destroy(ctx); + SAFE_FREE(sharename); + return -1; + } if (!string_to_sid(&sid, name)) { /* Convert to a SID */ NTSTATUS ntstatus = net_lookup_sid_from_name(ctx, name, &sid); |