diff options
| author | Luke Leighton <lkcl@samba.org> | 2000-02-04 04:59:31 +0000 |
|---|---|---|
| committer | Luke Leighton <lkcl@samba.org> | 2000-02-04 04:59:31 +0000 |
| commit | bbe275e95b86bc7af5a641455cbb379974823f84 (patch) | |
| tree | 9dfa5cc96c8634b5a5810414109560fd5d4391b4 /source3/utils | |
| parent | ae7696117e81bb469fa71f9bc880f6b5aac0724e (diff) | |
| download | samba-bbe275e95b86bc7af5a641455cbb379974823f84.tar.gz samba-bbe275e95b86bc7af5a641455cbb379974823f84.tar.bz2 samba-bbe275e95b86bc7af5a641455cbb379974823f84.zip | |
1) added void* state argument to tdb_traverse. guess what! there were
two places i found where it was appropriate to _use_ that third argument,
in locking.c and brlock.c! there was a static traverse_function and
i removed the static variable, typecast it to a void*, passed it to
tdb_traverse and re-cast it back to the traverse_function inside the
tdb_traverse function. this makes the use of tdb_traverse() reentrant,
which is never going to happen, i know, i just don't like to see
statics lying about when there's no need for them.
as i had to do in samba-tng, all uses of tdb_traverse modified to take
the new void* state argument.
2) disabled rpcclient: referring people to use SAMBA_TNG rpcclient.
i don't know how the other samba team members would react if i deleted
rpcclient from cvs main. damn, that code's so old, it's unreal.
20 rpcclient commands, instead of about 70 in SAMBA_TNG.
(This used to be commit 49d7f0afbc1c5425d53019e234d54ddf205c8e9a)
Diffstat (limited to 'source3/utils')
| -rw-r--r-- | source3/utils/status.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/utils/status.c b/source3/utils/status.c index 3f618dcd17..5c01409737 100644 --- a/source3/utils/status.c +++ b/source3/utils/status.c @@ -180,7 +180,7 @@ static int profile_dump(void) } -static int traverse_fn1(TDB_CONTEXT *tdb, TDB_DATA kbuf, TDB_DATA dbuf) +static int traverse_fn1(TDB_CONTEXT *tdb, TDB_DATA kbuf, TDB_DATA dbuf, void *state) { static pid_t last_pid; struct session_record *ptr; @@ -326,7 +326,7 @@ static int traverse_fn1(TDB_CONTEXT *tdb, TDB_DATA kbuf, TDB_DATA dbuf) printf("Service uid gid pid machine\n"); printf("----------------------------------------------\n"); } - tdb_traverse(tdb, traverse_fn1); + tdb_traverse(tdb, traverse_fn1, NULL); locks: if (processes_only) exit(0); |