Remove "winbindd_request" and "winbindd_response" from winbindd_cli_state

This shrinks the memory footprint of an idle client by 5592 bytes to 60 bytes
on my 32-bit box.

1 files changed, 10 insertions, 6 deletions

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 9cc1bf2701..0a73c0ebc6 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -531,11 +531,6 @@ static void process_request(struct winbindd_cli_state *state)
 	struct winbindd_dispatch_table *table = dispatch_table;
 	struct winbindd_async_dispatch_table *atable;
 
-	ZERO_STRUCTP(state->response);
-
-	state->response->result = WINBINDD_PENDING;
-	state->response->length = sizeof(struct winbindd_response);
-
 	state->mem_ctx = talloc_init("winbind request");
 	if (state->mem_ctx == NULL)
 		return;
@@ -570,6 +565,16 @@ static void process_request(struct winbindd_cli_state *state)
 		return;
 	}
 
+	state->response = talloc_zero(state->mem_ctx,
+				      struct winbindd_response);
+	if (state->response == NULL) {
+		DEBUG(10, ("talloc failed\n"));
+		remove_client(state);
+		return;
+	}
+	state->response->result = WINBINDD_PENDING;
+	state->response->length = sizeof(struct winbindd_response);
+
 	for (table = dispatch_table; table->fn; table++) {
 		if (state->request->cmd == table->cmd) {
 			DEBUG(10,("process_request: request fn %s\n",
@@ -709,7 +714,6 @@ static void new_connection(int listen_sock, bool privileged)
 	}
 
 	state->sock = sock;
-	state->response = &state->_response;
 
 	state->out_queue = tevent_queue_create(state, "winbind client reply");
 	if (state->out_queue == NULL) {