diff options
| author | todd stecher <todd.stecher@gmail.com> | 2009-01-19 15:09:51 -0800 |
|---|---|---|
| committer | Steven Danneman <steven.danneman@isilon.com> | 2009-01-21 17:13:03 -0800 |
| commit | 989ad44d32c2e77972a966d91f1813b0b929f83b (patch) | |
| tree | bb7a41c961fe974f464f7ce2a27ca3bf055187bf /source3/winbindd/winbindd_group.c | |
| parent | e9615b43b4dc7037da7bc274d720b8e54c7f85bc (diff) | |
| download | samba-989ad44d32c2e77972a966d91f1813b0b929f83b.tar.gz samba-989ad44d32c2e77972a966d91f1813b0b929f83b.tar.bz2 samba-989ad44d32c2e77972a966d91f1813b0b929f83b.zip | |
Memory leaks and other fixes found by Coverity
Diffstat (limited to 'source3/winbindd/winbindd_group.c')
| -rw-r--r-- | source3/winbindd/winbindd_group.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/source3/winbindd/winbindd_group.c b/source3/winbindd/winbindd_group.c index 7432bda451..bc532bbce7 100644 --- a/source3/winbindd/winbindd_group.c +++ b/source3/winbindd/winbindd_group.c @@ -991,7 +991,13 @@ static void getgrgid_recv(void *private_data, bool success, const char *sid) DEBUG(10,("getgrgid_recv: gid %lu has sid %s\n", (unsigned long)(state->request.data.gid), sid)); - string_to_sid(&group_sid, sid); + if (!string_to_sid(&group_sid, sid)) { + DEBUG(1,("getgrgid_recv: Could not convert sid %s " + "from string\n", sid)); + request_error(state); + return; + } + winbindd_getgrsid(state, group_sid); return; } |