summaryrefslogtreecommitdiff
path: root/source3/winbindd
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2008-03-25 22:21:50 +0100
committerGünther Deschner <gd@samba.org>2008-03-25 23:36:06 +0100
commit689cd9e1012bba0a4e9a7da4bbf8b2833e0f1684 (patch)
tree36c4a61aa54070f0379fa3c3e94b24327715a557 /source3/winbindd
parent04cd5c6bd8bb0b18e631ba3a42d004ac959bf106 (diff)
downloadsamba-689cd9e1012bba0a4e9a7da4bbf8b2833e0f1684.tar.gz
samba-689cd9e1012bba0a4e9a7da4bbf8b2833e0f1684.tar.bz2
samba-689cd9e1012bba0a4e9a7da4bbf8b2833e0f1684.zip
Fix a segfault
When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized at all. So first check that we have NT_STATUS_IS_OK(status) before we dereference my_info3. (This used to be commit 559cd9e5a7fac3ce3769d457132cdcb28569b93d)
Diffstat (limited to 'source3/winbindd')
-rw-r--r--source3/winbindd/winbindd_pam.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index c56eb1b3f8..5712f08603 100644
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -1362,7 +1362,7 @@ NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain,
* caller, we look up the account flags ourselve - gd */
if ((state->request.flags & WBFLAG_PAM_INFO3_TEXT) &&
- (my_info3->base.acct_flags == 0) && NT_STATUS_IS_OK(result)) {
+ NT_STATUS_IS_OK(result) && (my_info3->base.acct_flags == 0)) {
struct rpc_pipe_client *samr_pipe;
POLICY_HND samr_domain_handle, user_pol;