summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2013-10-16 21:02:42 +0200
committerJeremy Allison <jra@samba.org>2013-10-19 03:43:04 +0200
commit28cdd1c46fec1bffa380c7be6122fb7ee05a9359 (patch)
tree5038b8c0e12a8e2327dc4ae3b1ecd6ffe344a1a8 /source3
parent36f4f72060b44e0b2d4563a24f9e811a8fe87eef (diff)
downloadsamba-28cdd1c46fec1bffa380c7be6122fb7ee05a9359.tar.gz
samba-28cdd1c46fec1bffa380c7be6122fb7ee05a9359.tar.bz2
samba-28cdd1c46fec1bffa380c7be6122fb7ee05a9359.zip
winbind3: Fix CID 1107229 Uninitialized pointer read
The first "goto done" would TALLOC_FREE the uninitialized "value" Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Oct 19 03:43:04 CEST 2013 on sn-devel-104
Diffstat (limited to 'source3')
-rw-r--r--source3/winbindd/winbindd_cm.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index ace0160a1c..edb2c7bac4 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1565,7 +1565,8 @@ bool fetch_current_dc_from_gencache(TALLOC_CTX *mem_ctx,
const char *domain_name,
char **p_dc_name, char **p_dc_ip)
{
- char *key, *value, *p;
+ char *key, *p;
+ char *value = NULL;
bool ret = false;
char *dc_name = NULL;
char *dc_ip = NULL;