diff options
| author | Stefan Metzmacher <metze@samba.org> | 2011-06-16 12:47:22 +0200 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2011-06-16 14:15:47 +0200 |
| commit | 67512152c007bb186e4fd8dac5d1aab89bce0689 (patch) | |
| tree | e36ba4065ea38b926b42f52bbd2ff9cd62789de5 /source3 | |
| parent | 11683ccf3e68606ecb1cdfa455f7921b119803c6 (diff) | |
| download | samba-67512152c007bb186e4fd8dac5d1aab89bce0689.tar.gz samba-67512152c007bb186e4fd8dac5d1aab89bce0689.tar.bz2 samba-67512152c007bb186e4fd8dac5d1aab89bce0689.zip | |
s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()
r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it, even if it's smaller than the offered buffer size.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/rpc_server/svcctl/srv_svcctl_nt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/rpc_server/svcctl/srv_svcctl_nt.c b/source3/rpc_server/svcctl/srv_svcctl_nt.c index 8523def037..f515906339 100644 --- a/source3/rpc_server/svcctl/srv_svcctl_nt.c +++ b/source3/rpc_server/svcctl/srv_svcctl_nt.c @@ -936,7 +936,7 @@ WERROR _svcctl_QueryServiceObjectSecurity(struct pipes_struct *p, } *r->out.needed = len; - r->out.buffer = buffer; + memcpy(r->out.buffer, buffer, len); return WERR_OK; } |