diff options
| author | Jeremy Allison <jra@samba.org> | 2012-06-15 21:10:37 -0700 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2012-06-15 21:10:37 -0700 |
| commit | 816c40cb0d6cfa39690e5a9ccca914c731f898a3 (patch) | |
| tree | be8b6604e21bec4f5656abd2e272929f9ae7f4e5 /source3 | |
| parent | 985dbedf2764b63048d4ae7a2fd319b1e3560229 (diff) | |
| download | samba-816c40cb0d6cfa39690e5a9ccca914c731f898a3.tar.gz samba-816c40cb0d6cfa39690e5a9ccca914c731f898a3.tar.bz2 samba-816c40cb0d6cfa39690e5a9ccca914c731f898a3.zip | |
Fix Bug 8989 - Samba 3.5.x (and probably all other versions of Samba) does not send correct responses to NT Transact Secondary when no data and no params
Found by Richard Sharpe <realrichardsharpe@gmail.com>. The correct
command code in a reply to NT Transact Secondary (0xa1) is
NT Transact (0xa0).
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/smbd/nttrans.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c index 3721125166..5410fcb219 100644 --- a/source3/smbd/nttrans.c +++ b/source3/smbd/nttrans.c @@ -2928,6 +2928,12 @@ void reply_nttranss(struct smb_request *req) show_msg((const char *)req->inbuf); + /* Windows clients expect all replies to + an NT transact secondary (SMBnttranss 0xA1) + to have a command code of NT transact + (SMBnttrans 0xA0). See bug #8989 for details. */ + req->cmd = SMBnttrans; + if (req->wct < 18) { reply_nterror(req, NT_STATUS_INVALID_PARAMETER); END_PROFILE(SMBnttranss); |