summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2007-03-23 17:00:00 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 12:18:51 -0500
commitb3646bd809fc7688145d3e4a7b90fb8a64979a48 (patch)
treea2c54e41d1853aa759d3ad2c448b22f8be901775 /source3
parent6685e533854fe603043e219a4a91fbf779cde1dd (diff)
downloadsamba-b3646bd809fc7688145d3e4a7b90fb8a64979a48.tar.gz
samba-b3646bd809fc7688145d3e4a7b90fb8a64979a48.tar.bz2
samba-b3646bd809fc7688145d3e4a7b90fb8a64979a48.zip
r21947: Fix the equivalent of memcpy(x, x, 16). Found
by valgrind on the build farm. Jeremy. (This used to be commit 6eed92dfd4da1f9979831bec8e0dcdee33fb53b4)
Diffstat (limited to 'source3')
-rw-r--r--source3/libsmb/credentials.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/source3/libsmb/credentials.c b/source3/libsmb/credentials.c
index 76fc5fc062..3243719d5c 100644
--- a/source3/libsmb/credentials.c
+++ b/source3/libsmb/credentials.c
@@ -101,7 +101,9 @@ static void creds_init_64(struct dcinfo *dc,
unsigned char sum2[8];
/* Just in case this isn't already there */
- memcpy(dc->mach_pw, mach_pw, 16);
+ if (dc->mach_pw != mach_pw) {
+ memcpy(dc->mach_pw, mach_pw, 16);
+ }
sum[0] = IVAL(clnt_chal_in->data, 0) + IVAL(srv_chal_in->data, 0);
sum[1] = IVAL(clnt_chal_in->data, 4) + IVAL(srv_chal_in->data, 4);