r19831: Big ldb_dn optimization and interfaces enhancement patch

This patch changes a lot of the code in ldb_dn.c, and also
removes and add a number of manipulation functions around.

The aim is to avoid validating a dn if not necessary as the
validation code is necessarily slow. This is mainly to speed up
internal operations where input is not user generated and so we
can assume the DNs need no validation. The code is designed to
keep the data as a string if possible.

The code is not yet 100% perfect, but pass all the tests so far.
A memleak is certainly present, I'll work on that next.

Simo.
(This used to be commit a580c871d3784602a9cce32d33419e63c8236e63)

1 files changed, 3 insertions, 3 deletions

diff --git a/source4/dsdb/samdb/ldb_modules/schema.c b/source4/dsdb/samdb/ldb_modules/schema.c
index fe275ce841..f7bbb7b2c5 100644
--- a/source4/dsdb/samdb/ldb_modules/schema.c
+++ b/source4/dsdb/samdb/ldb_modules/schema.c
@@ -946,7 +946,7 @@ static int schema_check_attributes_syntax(struct schema_context *sctx)
 		if (attr == NULL) {
 			return LDB_ERR_NO_SUCH_ATTRIBUTE;
 		}
-		ret = schema_validate(&msg->elements[i], attr->syntax, attr->single, attr->min, attr->max);
+		ret = schema_validate(sctx->module->ldb, &msg->elements[i], attr->syntax, attr->single, attr->min, attr->max);
 		if (ret != LDB_SUCCESS) {
 			return ret;
 		}
@@ -1187,7 +1187,7 @@ static int schema_init(struct ldb_module *module)
 
 	/* find the schema partition */
 	ret = ldb_search(module->ldb,
-			 ldb_dn_new(module),
+			 ldb_dn_new(module, module->ldb, NULL),
 			 LDB_SCOPE_BASE,
 			 "(objectClass=*)",
 			 schema_attrs,
@@ -1200,7 +1200,7 @@ static int schema_init(struct ldb_module *module)
 		return LDB_ERR_OPERATIONS_ERROR;
 	}
 
-	data->schema_dn = ldb_msg_find_attr_as_dn(data, res->msgs[0], "schemaNamingContext");
+	data->schema_dn = ldb_msg_find_attr_as_dn(module->ldb, data, res->msgs[0], "schemaNamingContext");
 	if (data->schema_dn == NULL) {
 		/* FIXME: return a clear error string */
 		talloc_free(data);